Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support window.rowsBetween(Window.unboundedPreceding, -1) #5314

Closed
GaryShen2008 opened this issue Apr 26, 2022 · 1 comment · Fixed by #9229
Closed

[FEA] Support window.rowsBetween(Window.unboundedPreceding, -1) #5314

GaryShen2008 opened this issue Apr 26, 2022 · 1 comment · Fixed by #9229
Assignees
@mythrocks
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@GaryShen2008
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
In DLRM ETL code, we have a window operation as below.
windowed = Window.partitionBy('column_id').orderBy('part_id').rowsBetween(Window.unboundedPreceding, -1)

The explain log says:
!Expression sum(diff#143L) windowspecdefinition(column_id#120, part_id#123 ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), -1)) cannot run on GPU
because upper-bounds behind the current row is not supported. Found -1

Describe the solution you'd like
GPU can support such window operation.
@GaryShen2008 GaryShen2008 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 26, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Apr 26, 2022
@sameerz sameerz added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Sep 6, 2023
@mythrocks mythrocks mentioned this issue Sep 13, 2023
Merged
@mythrocks
Copy link
Collaborator

mythrocks commented Sep 13, 2023 •
edited
Loading

Addressed by #9229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mythrocks mythrocks

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@mythrocks @sameerz @GaryShen2008