Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] QualificationTool. Add speedup information to AppSummaryInfo #5449

Closed
amahussein opened this issue May 10, 2022 · 0 comments · Fixed by #5454
Closed

[FEA] QualificationTool. Add speedup information to AppSummaryInfo #5449

amahussein opened this issue May 10, 2022 · 0 comments · Fixed by #5454
Assignees
Labels
feature request New feature or request tools

Comments

@amahussein
Copy link
Collaborator

Splitting Scope of #5176

Is your feature request related to a problem? Please describe.

1- We need to add more information to the output of the Qualification tool:

    longestSqlDuration: Long,
    nonSqlTaskDurationAndOverhead: Long,
    estimatedDuration: Double,
    unsupportedDuration: Long,
    speedupDuration: Long,
    speedupFactor: Double,
    totalSpeedup: Double,
    speedupBucket: String

2- Add a cmdLine option to generate UI report.
By default is is disabled.
For the first initial commit, enabling the flag won't generate UI report because the static code generation is not merged yet.

Describe the solution you'd like

  • longestSqlDuration: returns Max(sqlDurationTime)
  • nonSqlTaskDurationAndOverhead: Assume that overhead is the all time windows that do not overlap with a running job.
  • unsupportedDuration: Considering sqlDataframeTaskDuration, this will sum-up all operators that are not supported by RAPIDS.
  • speedupDuration: the duration that can take advantage of the GPU acceleration. sqlDataframeTaskDuration - unsupportedDuration.
  • speedupFactor: assuming that there is a speedup factor for each operator. The speedupFactor is the aggregate of all the operators.
  • estimatedDuration: duration of the app if it was executed on the GPU. Note that the overhead still counts. (speedupDuration/speedupFactor) + unsupportedDuration + nonSQLDuration
  • totalSpeedup: ratio between appTaskDuration and estimatedDuration where appTaskDuration is nonSQLDuration + sqlDataframeTaskDuration
  • speedupBucket: this represents the classification of the app (Strongly Recommended, Recommended, Not Recommended)
    total_speedup = app_duration / estimated_duration
if (total_speedup > 3) 
then speedup_bucket to Strongly Recommended
else if (total_speedup > 1.25) 
then speedup_bucket to Recommended
else 
speedup_bucket to Not Recommended

Additional context

This request is to split #5176 (and the draft PR #5407) to separate between UI code generation and the extensions needed to be done in the Qualification tool to generate a summary about GPU Recommendations

@amahussein amahussein added feature request New feature or request ? - Needs Triage Need team to review and classify tools labels May 10, 2022
@amahussein amahussein added this to the May 2 - May 20 milestone May 10, 2022
@amahussein amahussein self-assigned this May 10, 2022
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants