Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] avg literals bools is failing on 330 #5496

Closed
firestarman opened this issue May 16, 2022 · 1 comment · Fixed by #5529
Closed

[BUG] avg literals bools is failing on 330 #5496

firestarman opened this issue May 16, 2022 · 1 comment · Fixed by #5529
Assignees
@revans2
Labels
bug Something isn't working P0 Must have for release
Milestone
May 2 - May 20

Comments

@firestarman
Copy link
Collaborator

firestarman commented May 16, 2022 •
edited
Loading

Describe the bug
HashAggregatesSuite:

  • avg literals bools fail *** FAILED ***

Steps/Code to reproduce bug
mvn clean test -Dbuildver=330
@firestarman firestarman added bug Something isn't working ? - Needs Triage Need team to review and classify labels May 16, 2022
@sameerz sameerz added P0 Must have for release and removed ? - Needs Triage Need team to review and classify labels May 17, 2022
@revans2
Copy link
Collaborator

revans2 commented May 18, 2022

I am not 100% sure what happened, but Spark assumes for aggregations that each aggregation has a name. The error we are getting in 3.3 indicates that avg(true) didn't have a name. When I give it a name, then we get the old error back. I guess a rule changed somewhere and is not assigning a name to this invalid case, but I don't know for sure.

@revans2 revans2 mentioned this issue May 18, 2022
Merged
@revans2 revans2 added this to the May 2 - May 20 milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
bug Something isn't working P0 Must have for release
Projects
None yet
Milestone
May 2 - May 20
Development

Successfully merging a pull request may close this issue.

Fix failing bool agg test in Spark 3.3 revans2/spark-rapids
3 participants
@revans2 @sameerz @firestarman