Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update CudfUnsafeRow to include size estimates for strings and implementation for getUTF8String #5634

Open
mattahrens opened this issue May 25, 2022 · 1 comment · Fixed by #5998
Open

[FEA] Update CudfUnsafeRow to include size estimates for strings and implementation for getUTF8String #5634

mattahrens opened this issue May 25, 2022 · 1 comment · Fixed by #5998
Assignees
@amahussein
Labels
feature request New feature or request performance A performance related task/issue

Comments

@mattahrens
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Update CudfUnsafeRow to include:

  • size estimates for Strings (does not have to be perfect) Spark uses 20 bytes as an estimate for the size of the String itself.
  • Add in an implementation for getUTF8String to read the offset and size. I think the code that is commented out is close, but needs to be modified because we don't guarantee 64-bit alignment for this.

Ref: rapidsai/cudf#10033 (comment)
@mattahrens mattahrens added feature request New feature or request ? - Needs Triage Need team to review and classify labels May 25, 2022
@mattahrens mattahrens mentioned this issue May 25, 2022
Open
@mattahrens mattahrens added performance A performance related task/issue and removed ? - Needs Triage Need team to review and classify labels May 31, 2022
@amahussein amahussein mentioned this issue Jul 13, 2022
Merged
@amahussein amahussein self-assigned this Jul 13, 2022
@amahussein amahussein mentioned this issue Jul 22, 2022
Open
@amahussein
Copy link
Collaborator

reopened by #6367

@amahussein amahussein reopened this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
feature request New feature or request performance A performance related task/issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Strings as a supported type for GpuColumnarToRow transitions amahussein/spark-rapids
2 participants
@mattahrens @amahussein