Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Update GeneratedInternalRowToCudfRowIterator for string transitions #5636

Open
mattahrens opened this issue May 25, 2022 · 1 comment · Fixed by #5998
Open

[FEA] Update GeneratedInternalRowToCudfRowIterator for string transitions #5636

mattahrens opened this issue May 25, 2022 · 1 comment · Fixed by #5998
Assignees
Labels
feature request New feature or request performance A performance related task/issue

Comments

@mattahrens
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Update GeneratedInternalRowToCudfRowIterator. Be careful though this is the hard part because it does code generation to speed thing up. Also you might want to rename it because it is not going to CudfRow, it is going to a ColumnarBatch.

  • This means we are going to need to have a version of copyData for the String that puts in the offset and length at the fixed length location and then writes the string data to the offset after the fixed width portion. Then updates a new offset value so later Strings can use it.

Ref: rapidsai/cudf#10033 (comment)

@amahussein
Copy link
Collaborator

reopened by #6367

@amahussein amahussein reopened this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request performance A performance related task/issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants