Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Move _databricks_internal check to shim layer #6279

Closed
andygrove opened this issue Aug 10, 2022 · 0 comments · Fixed by #6813
Closed

[FEA] Move _databricks_internal check to shim layer #6279

andygrove opened this issue Aug 10, 2022 · 0 comments · Fixed by #6813
Assignees
@cindyyuanjiang
Labels
tech debt

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
PR #6257 added a check for _databricks_internal for 22.08. We need to move check to the shim layer so that we only look for this when running on Databricks.

Describe the solution you'd like
As above.

Describe alternatives you've considered
None

Additional context
None
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 10, 2022
@andygrove andygrove added this to the Aug 8 - Aug 19 milestone Aug 10, 2022
@andygrove andygrove self-assigned this Aug 10, 2022
@andygrove andygrove mentioned this issue Aug 10, 2022
Merged
@sameerz sameerz removed this from the Aug 8 - Aug 19 milestone Aug 20, 2022
@sameerz sameerz added tech debt and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 23, 2022
@andygrove andygrove removed their assignment Sep 23, 2022
@cindyyuanjiang cindyyuanjiang self-assigned this Oct 13, 2022
@cindyyuanjiang cindyyuanjiang mentioned this issue Oct 14, 2022
Merged
@cindyyuanjiang cindyyuanjiang linked a pull request Oct 17, 2022 that will close this issue
Move _databricks_internal check to shim layer [databricks] #6813
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindyyuanjiang cindyyuanjiang

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move _databricks_internal check to shim layer [databricks] cindyyuanjiang/spark-rapids
3 participants
@andygrove @sameerz @cindyyuanjiang