Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Refactor shims to remove dependency from 340 to 330db for cast/try_cast #8188

Closed
andygrove opened this issue Apr 26, 2023 · 1 comment
Closed

[FEA] Refactor shims to remove dependency from 340 to 330db for cast/try_cast #8188

andygrove opened this issue Apr 26, 2023 · 1 comment
Assignees
@andygrove
Labels
task Work required that improves the product but is not user facing

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This is a follow on issue related to #8179

The shim implementation for cast/try_cast is confusing and results in the 340 shim depending on the 330db shim.

See #8179 (comment) for more detail

Describe the solution you'd like
Refactor the shims for cast/try_cast so that 340 shim does not depend on 330db shim

Describe alternatives you've considered

Additional context
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 26, 2023
@andygrove andygrove self-assigned this Apr 26, 2023
@andygrove andygrove mentioned this issue Apr 26, 2023
Merged
@revans2
Copy link
Collaborator

revans2 commented Apr 26, 2023

Actually I was wrong. It is confusing but I forgot about how complex the problem is that we are trying to solve. I think it is find the way it is.

@revans2 revans2 closed this as completed Apr 26, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Apr 27, 2023
@sameerz sameerz added task Work required that improves the product but is not user facing and removed feature request New feature or request labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andygrove @revans2 @mattahrens @sameerz