Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support Retry on HostColumnarToGpu #8326

Closed
revans2 opened this issue May 18, 2023 · 0 comments · Fixed by #9434
Closed

[FEA] Support Retry on HostColumnarToGpu #8326

revans2 opened this issue May 18, 2023 · 0 comments · Fixed by #9434
Assignees
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented May 18, 2023

Is your feature request related to a problem? Please describe.
HostColumnarToGpu is concatenating the data in host memory before sending it down to the GPU. We cannot really support split and retry here without having a way for our HostColumnarBuilder to also split it's input. Plus that feels like a very badly configured query where we don't have enough memory to process a single batch of data that matches the target batch size.

Describe the solution you'd like
This needs to be a little bit different from the other AbstractGpuCoalesceIterator retry implementations. Here we just want the retry to be in HostToGpuCoalesceIterator.concatAllAndPutOnGPU All of the rest of the processing is done on the CPU.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels May 18, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label May 24, 2023
@firestarman firestarman self-assigned this Oct 12, 2023
@sameerz sameerz removed the feature request New feature or request label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants