Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add Retry support to GeneratedInternalRowToCudfRowIterator #8349

Closed
revans2 opened this issue May 22, 2023 · 1 comment · Fixed by #9169
Closed

[FEA] Add Retry support to GeneratedInternalRowToCudfRowIterator #8349

revans2 opened this issue May 22, 2023 · 1 comment · Fixed by #9169
Assignees
@abellina
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented May 22, 2023

Is your feature request related to a problem? Please describe.
This generates code that is run to convert internal rows into something that the GPU can convert to a Table internally. At a minimum we should support retry for this (The part that copies data to the GPU and converts it to a Table). Ideally we could support splitAndRetry too, but that would require us to be able to split the CPU data and I don't know how simple that is to pull off.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels May 22, 2023
@revans2 revans2 mentioned this issue May 22, 2023
Open
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label May 24, 2023
@sameerz sameerz removed the feature request New feature or request label Jun 29, 2023
@abellina
Copy link
Collaborator

I am planning on taking this on.

@abellina abellina assigned abellina and unassigned revans2 and jbrennan333 Aug 25, 2023
@abellina abellina mentioned this issue Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abellina abellina

Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add retry-without-split in InternalRowToColumnarBatchIterator abellina/spark-rapids
5 participants
@abellina @revans2 @mattahrens @sameerz @jbrennan333