Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update JSON, CSV, and HiveText to retry host memory allocations #8888

Open
revans2 opened this issue Jul 31, 2023 · 0 comments
Open

[FEA] Update JSON, CSV, and HiveText to retry host memory allocations #8888

revans2 opened this issue Jul 31, 2023 · 0 comments
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin task Work required that improves the product but is not user facing

Comments

@revans2
Copy link
Collaborator

revans2 commented Jul 31, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
The JSON, CSV, and HiveText input file formats allocate host memory buffers to store data in. Then once they have enough data they will send it to the GPU to parse.

#9862 should update the allocations to be limited where needed, but we need to make sure that the allocation is in a retry block. We don't really need to make this spillable as there should only be a single buffer allocated.
@revans2 revans2 added ? - Needs Triage Need team to review and classify task Work required that improves the product but is not user facing reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels Jul 31, 2023
@revans2 revans2 mentioned this issue Jul 31, 2023
Open
30 tasks
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Aug 8, 2023
@revans2 revans2 changed the title [FEA] Update JSON, CSV, and HiveText to limit host memory usage [FEA] Update JSON, CSV, and HiveText to retry host memory allocations Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@revans2 @mattahrens