Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up setSpillable/doSetSpillable #9076

Closed
jlowe opened this issue Aug 18, 2023 · 2 comments · Fixed by #9172
Closed

Clean up setSpillable/doSetSpillable #9076

jlowe opened this issue Aug 18, 2023 · 2 comments · Fixed by #9172
Assignees

Comments

@jlowe
Copy link
Member

jlowe commented Aug 18, 2023

The RapidsBufferStore has a setSpillable and a doSetSpillable, both with the same visibility. One by default throws, while the other does not. This is very confusing, especially since the code is not consistent in which version is called, e.g.: updateSpillability calls doSetSpillable rather than setSpillable. IMO there should just be a single setSpillable function that should do nothing on stores that don't spill rather than have this confusing distinction.

@jlowe jlowe added ? - Needs Triage Need team to review and classify tech debt labels Aug 18, 2023
@abellina abellina self-assigned this Aug 18, 2023
@abellina
Copy link
Collaborator

Assigning this to myself and in this iteration. It is very small but it will improve the code and remove confusion. @mattahrens fyi. I also don't want to forget about it.

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Aug 22, 2023
@abellina
Copy link
Collaborator

Related issue: #9121, more cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants