Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Refactor GpuCast to take CastOptions #9284

Closed
razajafri opened this issue Sep 21, 2023 · 0 comments · Fixed by #9285
Closed

[FEA] Refactor GpuCast to take CastOptions #9284

razajafri opened this issue Sep 21, 2023 · 0 comments · Fixed by #9285
Assignees
@razajafri
Labels
task Work required that improves the product but is not user facing

Comments

@razajafri
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, GpuCast object takes in three parameters which is fine but as we make more changes pertaining to #9221 and #9220 it gets challenging

Describe the solution you'd like
Introduce an object that can be initialized to whatever options we want that can be used. We can also create singletons for the commonly used options like Arithmetic, Default and Ansi
@razajafri razajafri added feature request New feature or request ? - Needs Triage Need team to review and classify labels Sep 21, 2023
@razajafri razajafri self-assigned this Sep 21, 2023
@razajafri razajafri mentioned this issue Sep 21, 2023
Merged
@sameerz sameerz added task Work required that improves the product but is not user facing and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
2 participants
@sameerz @razajafri