Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Audit] SPARK-44448 Wrong results for dense_rank() <= k #9428

Closed
NVnavkumar opened this issue Oct 12, 2023 · 1 comment
Closed

[Audit] SPARK-44448 Wrong results for dense_rank() <= k #9428

NVnavkumar opened this issue Oct 12, 2023 · 1 comment
Assignees
@revans2
Labels
audit_3.5.0 bug Something isn't working

Comments

@NVnavkumar
Copy link
Collaborator

Apache spark fixed a bug in dense_rank (specifically in DenseRankLimitIterator), specifically an optimization that was introduced in Spark 3.5.0. We should verify the plugin GPU behavior is correct on future Spark 3.5.x releases, and that we are potentially consistent with the issue in 3.5.0.

apache/spark@f35c814f9b
@NVnavkumar NVnavkumar added bug Something isn't working ? - Needs Triage Need team to review and classify audit_3.5.0 labels Oct 12, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Oct 17, 2023
@revans2
Copy link
Collaborator

revans2 commented Oct 24, 2023

I manually ran the test and there were no issues. We still produced the correct answer, even with #8208 not being implemented. So no problems here.

@revans2 revans2 closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
audit_3.5.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@revans2 @mattahrens @NVnavkumar