Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AUD] Audit [SPARK-44897][SQL] Propagating local properties to subquery broadcastexec #9464

Closed
revans2 opened this issue Oct 17, 2023 · 0 comments · Fixed by #9610
Closed

[AUD] Audit [SPARK-44897][SQL] Propagating local properties to subquery broadcastexec #9464

revans2 opened this issue Oct 17, 2023 · 0 comments · Fixed by #9610
Assignees
@thirtiseven
Labels
audit_3.5.0

Comments

@revans2
Copy link
Collaborator

revans2 commented Oct 17, 2023

Is your feature request related to a problem? Please describe.

Spark added in apache/spark@2f4a71252cc

I am not 100% sure exactly which properties are not being propagated, but we do have essentially the same code that was touched in our GpuBroadcastExchangeExec

spark-rapids/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastExchangeExec.scala

Line 378 in 30e5a8f

lazy val relationFuture: Future[Broadcast[Any]] = {

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify audit_3.5.0 labels Oct 17, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Oct 24, 2023
@sameerz sameerz removed the feature request New feature or request label Oct 24, 2023
@thirtiseven thirtiseven self-assigned this Oct 31, 2023
@thirtiseven thirtiseven mentioned this issue Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thirtiseven thirtiseven

Labels
audit_3.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate local properties to broadcast execs thirtiseven/spark-rapids
4 participants
@revans2 @mattahrens @sameerz @thirtiseven