Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JDK11/17 in mvn-verify-ckeck matrix and internal CI #9619

Open
gerashegalov opened this issue Nov 2, 2023 · 3 comments
Open

Enable JDK11/17 in mvn-verify-ckeck matrix and internal CI #9619

gerashegalov opened this issue Nov 2, 2023 · 3 comments
Assignees
Labels
build Related to CI / CD or cleanly building Scala 2.13 Issues related to Scala 2.13 binaries test Only impacts tests

Comments

@gerashegalov
Copy link
Collaborator

It turns out that the fact that I was manually testing #9591 with JDK11/17 resolved the bug that non-default JDK
were not working prior to that.

git reset --hard  b5891fca00a9c85482147422358a51fd18cc1c0a
JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 mvn -B -f scala2.13 clean verify -Pjdk17 -DskipTests -Dmaven.repo.local=$PWD/.bloop-m2 

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  20.005 s
[INFO] Finished at: 2023-11-02T14:50:02-07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project rapids-4-spark-sql_2.13: Could not resolve dependencies for project com.nvidia:rapids-4-spark-sql_2.13:jar:23.12.0-SNAPSHOT: Could not find artifact com.nvidia:rapids-4-spark-private_2.13:jar:spark311:23.12.0-SNAPSHOT in snapshots-repo (https://oss.sonatype.org/content/repositories/snapshots) -> [Help 1]

which slipped through the cracks because we haven't enabled JDK11/17 check for Scala2.13. This issue tracks this work

@gerashegalov gerashegalov added test Only impacts tests build Related to CI / CD or cleanly building Scala 2.13 Issues related to Scala 2.13 binaries labels Nov 2, 2023
@pxLi
Copy link
Collaborator

pxLi commented Nov 3, 2023

hi @sameerz @GaryShen2008 any thoughts about this one?

I think existing scala2.12 + jdk11&17 would be enough, do we need to cover all combinations as limited resources? seems we are trying to cover work for JVM team too

@pxLi
Copy link
Collaborator

pxLi commented Nov 3, 2023

We can try start with adding some extra github actions. Lets mark this one lower priority for now cc @YanxuanLiu to help later

@gerashegalov
Copy link
Collaborator Author

We can try start with adding some extra github actions

This will help already. The bug was not caught exactly for the reason that we don't have any check making sure Scala2.13 at least builds with JDK11+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building Scala 2.13 Issues related to Scala 2.13 binaries test Only impacts tests
Projects
None yet
Development

No branches or pull requests

3 participants