TransactionID no longer used by Feeder Gateway, feeder.go still includes code to use it. [LOW SEVERITY]

[D-DePablos]

Describe the bug
See title

To Reproduce
GET request to: https://alpha-mainnet.starknet.io/feeder_gateway/get_transaction?transactionId=5425206

Expected behavior
Returns transaction information (in both Feeder gateway and feeder implementation)

Screenshots

[devenmatthews]

transactionId is still used by get_transaction_hash_by_id see here:
https://alpha-mainnet.starknet.io/feeder_gateway/get_transaction_hash_by_id?transactionId=100

Although GetTransactionStatus GetTransactionReceipt and GetTransaction are the only ones using TxnIdentifier and they do not support requests by transactionId.

I don't think it would make sense to use TxnIdentifier for get_transaction_hash_by_id. So potentially this can be removed.

I'd like to learn more about how feeder_gateway changes- because I'm unsure why GetTransaction does not support txId. I'm wondering if support may come in the future.

[D-DePablos]

I agree that feeder_gateway allows to go from hash <-> ID, but ID is not used aside from these calls. We can keep the functionality but I will not implement tx ID as it does not work with any other calls, and add a warning when hash is changed to ID.

The cairo-lang starknet CLI does not use any tx id as far as I have been able to see.