Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 support #301

Closed
zStupan opened this issue Mar 30, 2021 · 4 comments
Closed

Python 2.7 support #301

zStupan opened this issue Mar 30, 2021 · 4 comments

Comments

@zStupan
Copy link
Contributor

zStupan commented Mar 30, 2021

Python 2.7 has reached end of life, and numpy stopped supporting it since numpy 1.17, I think we should do the same in NiaPy 2.0

Thoughts?

@firefly-cpp
Copy link
Contributor

firefly-cpp commented Mar 30, 2021

Good point! I totally support this idea.

@GregaVrbancic what about you?

@sisco0
Copy link
Contributor

sisco0 commented Mar 30, 2021

Hello, please take a look at my modified CI version.
I got rid of Python 2.7 and used Python 3.8 in Windows and Linux.
If that is ok I could create a pull request for it.
You could get an idea of the fork at this comment, where I also link my fork branch.
#297 (comment)
I think that the project should migrate to Poetry as well, as now it seems like the standard for Python projects.
It should be studied if different versions of Python should be used for testing or not, if we use 3.8 (and possibly but optionally 3.9) that should be enough taking into account the people who uses our solution (mostly academic research people).
On this behalf, I remember we had a conversation on porting this library to C++ while creating Python bindings for it, that could lead to a robust solution as well.

@GregaVrbancic
Copy link
Contributor

Sure, we can drop the 2.7 support, this one is easy, but migration to the poetry package manager is a bit harder since all the scripts must be modified.

Regarding the testing versions of Python, in my opinion, we should test against all major versions. It is not the matter of who uses this package the most. On the other hand, we cannot be really sure that the academics really use the latest versions of Python. In my experience, it is quite the opposite, the academics tend to use older versions of Python.

@sisco0
Copy link
Contributor

sisco0 commented Apr 21, 2021

This issue could be closed with a32d637.

@zStupan zStupan closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants