Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ThrowingTask and CountingTask #317

Closed
zStupan opened this issue May 29, 2021 · 3 comments
Closed

Remove ThrowingTask and CountingTask #317

zStupan opened this issue May 29, 2021 · 3 comments

Comments

@zStupan
Copy link
Contributor

zStupan commented May 29, 2021

I feel like the ThrowingTask and the CountingTask should be removed, and only the StoppingTask should be kept. The Counting task is an unnecessary level of inheritance between Task and StoppingTask, and the ThrowingTask isn't used in any project, I doubt there's an actual use case for it.

My suggestion is, we keep only the StoppingTask and just name it Task. No inheritance needed.

What do you think?

@GregaVrbancic
Copy link
Contributor

I have also never used any other than StoppingTask, so from the application standpoint I don't think it's needed. But maybe there are some advantages of having those tasks for benchmarking different algorithms? @firefly-cpp what is your point of view on this?

@firefly-cpp
Copy link
Contributor

Hello all.

I totally support this idea. We need only Task. Thanks for pointing this issue out.

@zStupan
Copy link
Contributor Author

zStupan commented May 30, 2021

Fixed in #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants