Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata messed up in nix-prefetch-git etc #270

Closed
davidak opened this issue Jan 23, 2021 · 3 comments · Fixed by #278
Closed

Metadata messed up in nix-prefetch-git etc #270

davidak opened this issue Jan 23, 2021 · 3 comments · Fixed by #278
Labels
bug Something isn't working

Comments

@davidak
Copy link
Member

davidak commented Jan 23, 2021

I noticed that for some packages the metadata is messed up.

Screenshot from 2021-01-23 03-50-56

https://search.nixos.org/packages?channel=20.09&show=nix-prefetch-git&from=30&size=30&sort=relevance&query=nix

https://github.com/NixOS/nixpkgs/blob/nixos-20.09/pkgs/tools/package-management/nix-prefetch-scripts/default.nix

  • The License is missing, so the maintainer is displayed.
  • Instead of the maintainer, the description is displayed
  • The description is displayed as "Not specified" (which is wrong)
  • For long version, there is nothing. here "Not specified" would be correct
@davidak davidak added the bug Something isn't working label Jan 23, 2021
@samueldr
Copy link
Member

samueldr commented Jan 23, 2021

#261 re-does this interface. Meaning that, while this is valid, it won't be fixed as-is.

And yes, what is happening is that empty fields "disappear", following values go up once. This is why implementing a <table> like layout without using an actual <table> can sometimes be hard :). Here I believe the homepage field is the one that's missing.

@davidak
Copy link
Member Author

davidak commented Jan 23, 2021

Meaning that, while this is valid, it won't be fixed as-is.

ah, yes. sure

i tested it there

Screenshot from 2021-01-23 08-52-16

Homepage is not displayed there which is OK

Version and License is just empty which looks broken

@turboMaCk
Copy link
Member

turboMaCk commented Jan 23, 2021

I think problems like this or #269 are not on the UI side but in the python script we're using to populate the ES. Good catch. Definitely something that should be higher on our priority list to fix.

Edit: actually this like was just a bad display logic, apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants