Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue: Remove cargoSha256 attribute #241408

Closed
tjni opened this issue Jul 4, 2023 · 1 comment
Closed

Tracking Issue: Remove cargoSha256 attribute #241408

tjni opened this issue Jul 4, 2023 · 1 comment

Comments

@tjni
Copy link
Contributor

tjni commented Jul 4, 2023

I personally believe that we do not need this attribute in buildRustPackage. It lets us slightly simplify code and documentation, but mainly it's because, despite efforts, I always experience OCD-like compulsion to make it consistent.

I have read NixOS/rfcs#131 and see that reasonable minds differ, so I offer this issue as a discussion for Rust infra and package maintainers focused only on our Rust ecosystem.

I'm in favor of doing this and willing to put up some PRs for it (even if it only is until we find a way to move away from these hashes and their abuse of FODs altogether), so I'm especially interested in hearing objections. I'll seed the main concerns against doing this that I see expressed in that RFC:

  1. To support copying hash values in non-SRI formats from external sources, old versions of nix, or automation scripts.
  2. To maintain backwards compatibility.

to which I'll add a third:

  1. Not worth the time (e.g. reviewing, rebuilding, potentially fixing breakages).

/cc @NixOS/rust

@figsoda
Copy link
Member

figsoda commented Jul 5, 2023

I'm ok with requiring usage of cargoHash instead of cargoSha256 in newly added Rust packages, but I don't think actively changing existing packages is worth the time.

@tjni tjni closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants