Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid instantiating OpenAI in argument defaults #126

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Avoid instantiating OpenAI in argument defaults #126

merged 1 commit into from
Jan 22, 2024

Conversation

danlamanna
Copy link
Contributor

@NotJoeMartinez
Copy link
Owner

NotJoeMartinez commented Jan 22, 2024 •
edited
Loading

Interesting, was not aware that importing a function will cause the default args to be executed.
No way I would have caught this with non existent testing setup. Thanks for the fix.

@NotJoeMartinez NotJoeMartinez merged commit e81bf4d into NotJoeMartinez:main Jan 22, 2024
@danlamanna danlamanna deleted the fix-delete-openai-instantiation branch February 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting a channel requires OpenAI credentials
2 participants
@danlamanna @NotJoeMartinez