Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Grafana V8+ #16

Open
Flan5ter opened this issue Nov 19, 2021 · 2 comments
Open

Support for Grafana V8+ #16

Flan5ter opened this issue Nov 19, 2021 · 2 comments

Comments

@Flan5ter
Copy link

Hi,

I have not been able to get your plugin to work with Grafana v8 (8.2.5), I have signed the plugin and this works on v7.3.7. However when I upgraded to 8.2.5 it simply no longer appears in the plugins list. We are quite dependant on this plugin, do you have any plans to update to be compatible with v8 versions?

Kind regards
Andy

@ClaudioWaldvogel
Copy link
Contributor

Hi,

I just started Grafana 8.2.5 with CA APM Datasource in Docker.

docker run -p 3000:3000 -e GF_PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS=novatec-ca-apm-datasource -v ${PWD}/plugins:/var/lib/grafana/plugins grafana/grafana:8.2.5-ubuntu

Datasource appears as expected:
ca-ds-grafana-8 2 5

Do you see any errors in the Grafana Logs?

@Flan5ter
Copy link
Author

Flan5ter commented Nov 23, 2021

Hi,

For security reasons we are not allowed to run with that switch "PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS".

Since Grafana v7 and above unsigned plugins are not allowed. In v8 unsigned plugins are simply ignored.

I have managed to get the plugin signed, it's a convoluted process and npx is a pain.
export GRAFANA_API_KEY=<YOUR_API_KEY>
npx @grafana/toolkit plugin:sign --rootUrls https://example.com/grafana

image

For all our other 3rd party plugins we use the following commands and they are automatically installed as they are signed publicly within Grafana's repository. Some examples...

grafana-cli plugins install natel-discrete-panel
grafana-cli plugins install jdbranham-diagram-panel
grafana-cli plugins install grafana-image-renderer

Would it be possible for you to publish the signed plugin publicly in the Grafana plugin repository.
https://grafana.com/grafana/plugins/
https://grafana.com/docs/grafana/latest/developers/plugins/sign-a-plugin/

Snippets from the above URL
"You can create, sign and distribute plugins at no charge, provided that all dependent technologies are open source and not for profit. Community Plugins are published in the official Grafana catalog, and are available to the Grafana community."
"You can create, sign and distribute plugins with dependent technologies that are closed source or commercially backed, by entering into a Commercial Plugin Subscription with Grafana Labs. Commercial Plugins are published on the official Grafana catalog, and are available to the Grafana community."

With regards to this issue, please feel free to close as it is resolved. If it is possible for you to publish the plugin that would be great.

Kind regards
Andy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants