Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code for Dev OMNI calculations #1247

Open
msgilligan opened this issue Dec 16, 2021 · 0 comments
Open

Improve code for Dev OMNI calculations #1247

msgilligan opened this issue Dec 16, 2021 · 0 comments

Comments

@msgilligan
Copy link
Member

msgilligan commented Dec 16, 2021

The current code for Dev OMNI (formerly Dev MSC) calculations (omnicore.cpp: calculate_and_update_devmsc()) should be improved in one or more of the following ways:

  1. Refactor for clarity and improve comments -- see PR #1246 which is a first step
  2. Total Dev OMNI value is hard-coded for Omni main net and is not verified anywhere (that I know of) against the actual crowdsale OMNI totals
  3. The calculations use floating-point (double) and may have significant rounding errors or be platform-dependent
  4. More unit-test and functional tests
  5. The specification itself should probably be revised and/or clarified -- token issuance should use an algorithm similar to the Bitcoin issuance (i.e. using block height rather than timestamps and specifying per-block issuance directly in satoshis/willetts)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant