Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message or set default when Max Project Results is 0 #5227

Closed
JacobDeuchert opened this issue May 25, 2022 · 0 comments · Fixed by #5241
Closed

Show error message or set default when Max Project Results is 0 #5227

JacobDeuchert opened this issue May 25, 2022 · 0 comments · Fixed by #5241

Comments

@JacobDeuchert
Copy link

Is your feature request related to a problem? Please describe.

For some reason i had the Max Project Results setting set to 0. With the previous versions this setting worked fine with but with the latest 1.25.0 version omnisharp did not start or logged any kind of output.

Describe the solution you would like

I would be nice for other users which accidentally set the Max Project Results to 0 to either show a message in the omnisharp output log like "No launchTarges found. Make sure your workspace contains a .sln/.csproj file and your Max Project Results is set bigger 0"

Another solution would be to use 1 or 250 instead when set to 0.

Applicable Scenarios

User accidentally sets the Max Project Results to 0 and has a hard time finding the reason why omnisharp is not working and completly silent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant