Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright and Monitor Manual Execution #1689

Open
well-it-wasnt-me opened this issue Sep 9, 2024 · 8 comments
Open

Playwright and Monitor Manual Execution #1689

well-it-wasnt-me opened this issue Sep 9, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@well-it-wasnt-me
Copy link

Playwright Execution

When creating a Synthetic monitor would be nice to have a button like "PLAY" that you press it and run the code inside as the Monitor would.

Monitor Manual Execution

Every time you apply an update to a monitor you have to wait for it to be triggered...and then you know if the update is working or not.....also here....a chance to manually trigger it would be nice

@well-it-wasnt-me well-it-wasnt-me added the enhancement New feature or request label Sep 9, 2024
@simlarsen
Copy link
Contributor

Thank you for your feedback! We will def add this to our roadmap.

@well-it-wasnt-me
Copy link
Author

Thank you for your feedback! We will def add this to our roadmap.

My pleasure !

I guess we'll see who's gonna do it first then ! (Next weekend i will have time to dedicated to this)

@simlarsen
Copy link
Contributor

haha, please go ahead! :D

@ykns ykns mentioned this issue Sep 15, 2024
4 tasks
@ykns
Copy link

ykns commented Sep 15, 2024

@well-it-wasnt-me I hope you don't mind, that I've taken the liberty of tackling this

@well-it-wasnt-me
Copy link
Author

Not at all ! Open a dedicated branch. We can work on it togheter

@ykns
Copy link

ykns commented Sep 15, 2024

I've got a draft PR and it would be great to have your input

@well-it-wasnt-me
Copy link
Author

I'll check it out asap

@well-it-wasnt-me
Copy link
Author

Hey @ykns !

Left you few comments around your PR.

They are comments/suggestions/whatever...so don't take them as gold. Any feedback is appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants