Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Add eslint-disable block comment to typescript-axios generated files #6289

Closed
jfoliveira opened this issue May 13, 2020 · 2 comments · Fixed by #6613
Closed

[REQ] Add eslint-disable block comment to typescript-axios generated files #6289

jfoliveira opened this issue May 13, 2020 · 2 comments · Fixed by #6613

Comments

@jfoliveira
Copy link

Is your feature request related to a problem? Please describe.

As TSLint has been deprecated, and typescript-fetch already supports ESLint it would be nice to have the same ESLint support in typescript-axios generated .ts files.

Describe the solution you'd like

The line comment that instructs the linter to skip linting the generated file, instead of:

// tslint-disable

should contain

/* eslint-disable */

Describe alternatives you've considered

Manually doing a search and replace in all generated files replacing // tslint-disable with /* eslint-disable */ works, as expected.

Additional context

@macjohnny
Copy link
Member

@jfoliveira good idea, would you like to file a PR?

@sa9sha9
Copy link
Contributor

sa9sha9 commented Jun 10, 2020

@macjohnny
I'd sent you #6613 for this issue, could you please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants