Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Issues with 6.2.0 changes - Form opens up with errors #695

Closed
kkrumlian opened this issue Oct 4, 2023 · 3 comments · Fixed by #696
Closed

Issues with 6.2.0 changes - Form opens up with errors #695

kkrumlian opened this issue Oct 4, 2023 · 3 comments · Fixed by #696
Assignees
Milestone

Comments

@kkrumlian
Copy link

After merging 6.2.0 we are seeing a few issues when opening forms. Screenshots below reflect what we are seeing.

@kkrumlian kkrumlian changed the title Post Merge of 6.2.0 seeing some issues Issues with 6.2.0 changes - Form opens up with errors Oct 4, 2023
@kkrumlian
Copy link
Author

OpenClinica Participate 2023-09-28 11 AM-31-28
OpenClinica 2023-09-28 11 AM-33-38

@pbowen-oc pbowen-oc added this to the Next milestone Oct 4, 2023
@MartijnR
Copy link
Member

MartijnR commented Oct 12, 2023

Can be reproduced with:

curl --user enketorules: -d "server_url=http://localhost:3000&form_id=cascading&ecid=1&instance=\
<cascading xmlns:oc=\"http://openclinica.org/xforms\" oc:complete=\"false\">\
<page1><cascade1>1</cascade1><cascade2>1</cascade2><cascade3>1</cascade3></page1>\
<meta><instanceID>uuid:1234</instanceID></meta></cascading>\
&instance_id=a" http://localhost:8005/oc/api/v1/instance/edit/incomplete/rfc

in config/build.js setting splitting to false avoids the issue.

  • can splitting remain true? - not at the moment, I think. However, its usefulness might only be limited for a single page application (a few ms shorter load time?)

https://esbuild.github.io/api/#splitting
evanw/esbuild#16

Unfortunately, this build issue is hard to write a test for, since the issue doesn't actually occur in tests.

@MartijnR
Copy link
Member

first merge #697

then #696

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants