Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented limits in OpenCL filter config #163

Open
xlz opened this issue Feb 12, 2015 · 2 comments
Open

Undocumented limits in OpenCL filter config #163

xlz opened this issue Feb 12, 2015 · 2 comments

Comments

@xlz
Copy link
Member

xlz commented Feb 12, 2015

The depth result is blank with this config for OpenCL processor:

EnableBilateralFilter = false;
EnableEdgeAwareFilter = true;

It seems the edge aware filter filterPixelStage2 uses max_edge_test which is generated in the bilateral filter filterPixelStage1.

Is this a bug or a limitation in feature?

@floe floe added the bug label Feb 12, 2015
@kohrt
Copy link
Contributor

kohrt commented Feb 13, 2015

I think it is a feature. The edge aware filter is using results of the the bilateral filter. It is also a problem of the opengl processor. Either we should disable edge aware filter if bilateral filter is disabled or add code that calculates this max edge data if the bilateral filter is disable. But how likely is it that someone disabled bilateral filter but still wants to use the edge aware filter?

@MichaelKorn
Copy link

For me this is a bug. It should be easy to generate a warning.

@xlz xlz changed the title Depth problem with OpenCL processor Undocumented limits in OpenCL filter config Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants