Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environmental conditions to bring in line with OpenSCENARIO 1.x #544

Closed
caspar-ai opened this issue Jun 29, 2021 · 1 comment
Closed
Assignees
Labels
FeatureRequest Proposals which enhance the interface or add additional features. Harmonisation The Group in the ASAM development project working on harmonisation with other standards. SensorModeling The Group in the ASAM development project working on sensor modeling topics.

Comments

@caspar-ai
Copy link
Contributor

Describe the feature

Adding environmental conditions to OSI to match some of those already present in OpenSCENARIO 1.x.

Specifically, the following fields are present in the OSC Environment structure:

Describe the solution you would like

New fields added to the existing EnvironmentalConditions message.

Describe alternatives you have considered

Existing pattern so no other alternatives considered.

Describe the backwards compatibility

No issues for backwards compatibility, all new fields will be optional.

Additional context

This purpose of this ticket isn't to do full alignment, in particular there are existing disconnects between OSC and OSI where one uses a continuous value and the other uses an enum. That is a more complicated discussion and is already covered by #255 and so is considered outside the scope of this issue.

@caspar-ai caspar-ai added FeatureRequest Proposals which enhance the interface or add additional features. Harmonisation The Group in the ASAM development project working on harmonisation with other standards. labels Jun 29, 2021
@caspar-ai caspar-ai self-assigned this Jun 29, 2021
@thempen thempen added the SensorModeling The Group in the ASAM development project working on sensor modeling topics. label Aug 3, 2021
@HendrikAmelunxen HendrikAmelunxen added this to To do in Harmonisation via automation Aug 17, 2021
@HendrikAmelunxen HendrikAmelunxen moved this from To do to In progress in Harmonisation Sep 7, 2021
@HendrikAmelunxen
Copy link
Contributor

Closed; #593 is merged

@HendrikAmelunxen HendrikAmelunxen moved this from In progress to Merged/Done in Harmonisation May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest Proposals which enhance the interface or add additional features. Harmonisation The Group in the ASAM development project working on harmonisation with other standards. SensorModeling The Group in the ASAM development project working on sensor modeling topics.
Projects
Harmonisation
Merged/Done
Development

No branches or pull requests

3 participants