From e81e6b92b963299cf78699ff1f4b31c19555c2b5 Mon Sep 17 00:00:00 2001
From: "C. Brenhin Keller" <cbkeller@dartmouth.edu>
Date: Sat, 13 Apr 2024 21:46:01 -0400
Subject: [PATCH] Bugfix in kinetic uncertainty inversion

---
 src/inversion.jl | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/inversion.jl b/src/inversion.jl
index 6c92666..c6a9683 100644
--- a/src/inversion.jl
+++ b/src/inversion.jl
@@ -1088,7 +1088,7 @@
                 zi = 1
                 for i ∈ findall(tzr)
                     first_index = 1 + floor(Int64,(tinit - crystAge[i])/dt)
-                    calcHeAgesₚ[i] = HeAgeSpherical(zircons[zi], @views(Tstepsₚ[first_index:end]), @views(zpr[first_index:end,first_index:end]), zdm)::T
+                    calcHeAgesₚ[i] = HeAgeSpherical(zircons[zi], @views(Tstepsₚ[first_index:end]), @views(zpr[first_index:end,first_index:end]), zdmₚ)::T
                     zi += 1
                 end
             end
@@ -1097,7 +1097,7 @@
                 ai = 1
                 for i ∈ findall(tap)
                     first_index = 1 + floor(Int64,(tinit - crystAge[i])/dt)
-                    calcHeAgesₚ[i] = HeAgeSpherical(apatites[ai], @views(Tstepsₚ[first_index:end]), @views(apr[first_index:end,first_index:end]), adm)::T
+                    calcHeAgesₚ[i] = HeAgeSpherical(apatites[ai], @views(Tstepsₚ[first_index:end]), @views(apr[first_index:end,first_index:end]), admₚ)::T
                     ai += 1
                 end
             end
@@ -1456,8 +1456,8 @@
                 end
             else
                 # Adjust kinetic parameters, one at a time
-                rn = rand(1:7)
                 if any(tzr)
+                    rn = rand(1:4)
                     zdmₚ = ZRDAAM(
                         DzEa = (rn==1) ? exp(log(zdm.DzEa)+randn()*σzEa) : zdm.DzEa,
                         DzD0 = (rn==2) ? exp(log(zdm.DzD0)+randn()*σzD0) : zdm.DzD0,
@@ -1466,10 +1466,11 @@
                     )
                 end
                 if any(tap)
+                    rn = rand(1:3)
                     admₚ = RDAAM(
-                        D0L = (rn==5) ? exp(log(adm.D0L)+randn()*σaD0) : adm.D0L,
-                        EaL = (rn==6) ? exp(log(adm.EaL)+randn()*σaEa) : adm.EaL,
-                        EaTrap = (rn==7) ? exp(log(adm.EaTrap)+randn()*σaEa) : adm.EaTrap,
+                        D0L = (rn==1) ? exp(log(adm.D0L)+randn()*σaD0) : adm.D0L,
+                        EaL = (rn==2) ? exp(log(adm.EaL)+randn()*σaEa) : adm.EaL,
+                        EaTrap = (rn==3) ? exp(log(adm.EaTrap)+randn()*σaEa) : adm.EaTrap,
                     )
                 end
             end
@@ -1480,7 +1481,7 @@
                 zi = 1
                 for i ∈ findall(tzr)
                     first_index = 1 + floor(Int64,(tinit - crystAge[i])/dt)
-                    calcHeAgesₚ[i] = HeAgeSpherical(zircons[zi], @views(Tstepsₚ[first_index:end]), @views(zpr[first_index:end,first_index:end]), zdm)::T
+                    calcHeAgesₚ[i] = HeAgeSpherical(zircons[zi], @views(Tstepsₚ[first_index:end]), @views(zpr[first_index:end,first_index:end]), zdmₚ)::T
                     zi += 1
                 end
             end
@@ -1489,7 +1490,7 @@
                 ai = 1
                 for i ∈ findall(tap)
                     first_index = 1 + floor(Int64,(tinit - crystAge[i])/dt)
-                    calcHeAgesₚ[i] = HeAgeSpherical(apatites[ai], @views(Tstepsₚ[first_index:end]), @views(apr[first_index:end,first_index:end]), adm)::T
+                    calcHeAgesₚ[i] = HeAgeSpherical(apatites[ai], @views(Tstepsₚ[first_index:end]), @views(apr[first_index:end,first_index:end]), admₚ)::T
                     ai += 1
                 end
             end