Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No clear way of exiting the music application #55

Closed
NeonDaniel opened this issue Mar 2, 2023 · 4 comments · Fixed by #68
Closed

[BUG] No clear way of exiting the music application #55

NeonDaniel opened this issue Mar 2, 2023 · 4 comments · Fixed by #68

Comments

@NeonDaniel
Copy link
Member

Description

There is no clear method or command of exiting the music player application and returning to the main Neon dashboard clock screen (on mycroft II device).

Steps to Reproduce

No response

Relevant Code

No response

Other Notes

this may just be a documentation flaw but after trying numerous voice commands such as "cancel music" "exit music" "turn off music", "exit player" "exit music player" nothing so far has worked.

This was originally submitted by @msmick NeonGeckoCom/skill-free_music_archive#11

@JarbasAl
Copy link
Member

JarbasAl commented Mar 2, 2023

  • in ovos shell pull down and go to homescreen directly
  • use the auto timeout config option to return automatically after X time

suggested voice commands should probably be made a stop intent for OCP however

docs here for reference https://openvoiceos.github.io/community-docs/OCP/

@NeonDaniel
Copy link
Member Author

NeonDaniel commented Mar 28, 2023

I think a "close" button, similar to the homeassistant GUI might help here and/or returning to the homescreen on "stop" or with a dedicated intent to return to the homescreen. @AIIX might have an idea about if/I can how an exit button could be implemented

@AIIX
Copy link
Contributor

AIIX commented Mar 28, 2023

I can add an exit button similar to other apps to the UI optionally can be hidden so its only shown when the screen is tapped if we don't want to make it prominent and change the current UI look and feel, the second question is what does the exit button do in terms of behaviour, i.e. close the media player as in if playing audio via the GUI backend or continue playback and only close the UI the widget will become active once that happens, also in terms of Video it wouldn't make much sense to continue video playback so completely quit the app ? @NeonDaniel If I can get a behaviour defined would be helpful

@NeonDaniel
Copy link
Member Author

Related, there's no "stop" button in the player UI; this could be another option to stop playback and return to the homescreen (or OCP search or results page?).

Some ideas:

  • Stop button which stops current playback and clears the queue. This could return to the OCP search screen and wait for player timeout, or immediately return to the homescreen.

  • Close/exit button immediately closes OCP and returns to the homescreen. My preference would be for audio playback to continue with the homescreen widget and for video to pause, similar to the behavior on Android (minus the floating video player)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants