Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming TTS is only usable with paplay #218

Open
mikejgray opened this issue Apr 4, 2024 · 0 comments · May be fixed by #238
Open

Streaming TTS is only usable with paplay #218

mikejgray opened this issue Apr 4, 2024 · 0 comments · May be fixed by #238
Assignees
Labels
bug Something isn't working

Comments

@mikejgray
Copy link
Contributor

self.play_args = play_args or ["paplay"]

In the above code, play_args can override the default of ["paplay"], but it comes from the __init__() kwargs. Since self.config can't be accessed in a plugin until super().__init__() is called, it's not possible to pass this configuration from a plugin config.

Ideally the default would be the global player instead of hardcoded paplay to allow for other playback systems

@JarbasAl JarbasAl added the bug Something isn't working label May 17, 2024
@JarbasAl JarbasAl self-assigned this May 17, 2024
@mikejgray mikejgray linked a pull request Jun 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants