From 7569019e244a07139dacbe397215bf3af5fe1c3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mewen=20Le=20H=C3=B4?= <92363071+MewenLeHo@users.noreply.github.com> Date: Mon, 13 Feb 2023 12:06:14 +0100 Subject: [PATCH] fix(quantity selector): avoid using `.input-group` selector to match only quantity selector in JS (#1825) --- js/src/quantity-selector.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/js/src/quantity-selector.js b/js/src/quantity-selector.js index 90de167f7c..cc801899b7 100644 --- a/js/src/quantity-selector.js +++ b/js/src/quantity-selector.js @@ -26,7 +26,7 @@ const EVENT_CLICK_DATA_API = `click${EVENT_KEY}${DATA_API_KEY}` const SELECTOR_STEP_UP_BUTTON = '[data-bs-step="up"]' const SELECTOR_STEP_DOWN_BUTTON = '[data-bs-step="down"]' const SELECTOR_COUNTER_INPUT = '[data-bs-step="counter"]' -const SELECTOR_INPUT_GROUP = '.input-group' +const SELECTOR_QUANTITY_SELECTOR = '.input-group.quantity-selector' /** * Class definition @@ -59,7 +59,7 @@ class QuantitySelector extends BaseComponent { // Static static StepUp(event) { - const parent = event.target.closest(SELECTOR_INPUT_GROUP) + const parent = event.target.closest(SELECTOR_QUANTITY_SELECTOR) const counterInput = parent.querySelector(SELECTOR_COUNTER_INPUT) const max = counterInput.getAttribute('max') @@ -76,7 +76,7 @@ class QuantitySelector extends BaseComponent { } static StepDown(event) { - const parent = event.target.closest(SELECTOR_INPUT_GROUP) + const parent = event.target.closest(SELECTOR_QUANTITY_SELECTOR) const counterInput = parent.querySelector(SELECTOR_COUNTER_INPUT) const min = counterInput.getAttribute('min') @@ -93,7 +93,7 @@ class QuantitySelector extends BaseComponent { } static CheckIfDisabledOnChange(event) { - const parent = event.target.closest(SELECTOR_INPUT_GROUP) + const parent = event.target.closest(SELECTOR_QUANTITY_SELECTOR) const counterInput = parent.querySelector(SELECTOR_COUNTER_INPUT) const btnUp = parent.querySelector(SELECTOR_STEP_UP_BUTTON) const btnDown = parent.querySelector(SELECTOR_STEP_DOWN_BUTTON) @@ -140,7 +140,7 @@ EventHandler.on(document, EVENT_CLICK_DATA_API, SELECTOR_STEP_UP_BUTTON, Quantit EventHandler.on(document, EVENT_CLICK_DATA_API, SELECTOR_STEP_DOWN_BUTTON, QuantitySelector.StepDown) EventHandler.on(window, EVENT_LOAD_DATA_API, () => { - for (const el of SelectorEngine.find(SELECTOR_INPUT_GROUP)) { + for (const el of SelectorEngine.find(SELECTOR_QUANTITY_SELECTOR)) { QuantitySelector.getOrCreateInstance(el).ValueOnLoad(el) } })