Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Star rating images enhancement #2183

Closed
2 tasks done
louismaximepiton opened this issue Aug 2, 2023 · 0 comments · Fixed by #2184
Closed
2 tasks done

Star rating images enhancement #2183

louismaximepiton opened this issue Aug 2, 2023 · 0 comments · Fixed by #2184
Labels
css enhancement v5

Comments

@louismaximepiton
Copy link
Member

louismaximepiton commented Aug 2, 2023 •
edited
Loading

Prerequisites

Proposal

Use mask-image and background-color instead of background-image for star ratings.

Motivation and context

AFAICS, these are the benefits:

  • Ease the color mode by using CSS vars instead of Sass vars.
  • Lighten the bundle by importing the svgs only once.

It will also ease the new design. For now, we need to implement the svg for each size, color mode and states.

Just as an example: main...main-lmp-star-rating-enhancement
@louismaximepiton louismaximepiton mentioned this issue Aug 2, 2023
Merged
15 tasks
@julien-deramond julien-deramond changed the title Star rating Star rating images enhancement Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css enhancement v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Star rating: Refactoring + rebranding. Orange-OpenSource/Orange-Boosted-Bootstrap
1 participant
@louismaximepiton