From 43a518b69d95fb7c724f06cf28b1900de2cc8eb2 Mon Sep 17 00:00:00 2001 From: Artem M Date: Fri, 28 Feb 2020 15:52:54 +0200 Subject: [PATCH 1/2] Fix return type in docblock for successful inspection `Cells::get()`` can return `\PhpOffice\PhpSpreadsheet\Cell\Cell` that was found or `null` if not found --- src/PhpSpreadsheet/Collection/Cells.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PhpSpreadsheet/Collection/Cells.php b/src/PhpSpreadsheet/Collection/Cells.php index 84c3d3009c..458a9dae4d 100644 --- a/src/PhpSpreadsheet/Collection/Cells.php +++ b/src/PhpSpreadsheet/Collection/Cells.php @@ -434,7 +434,7 @@ public function add($pCoord, Cell $cell) * * @throws PhpSpreadsheetException * - * @return \PhpOffice\PhpSpreadsheet\Cell\Cell Cell that was found, or null if not found + * @return null|\PhpOffice\PhpSpreadsheet\Cell\Cell Cell that was found, or null if not found */ public function get($pCoord) { From ca2f40796995070bef3e9d6a1d9ff5aca77e624f Mon Sep 17 00:00:00 2001 From: Artem Molotov Date: Fri, 28 Feb 2020 16:47:44 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c2931dcab3..a1760df008 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org). - Handle ConditionalStyle NumberFormat When Reading Xlsx File [#1296](https://github.com/PHPOffice/PhpSpreadsheet/pull/1296) - Fix Xlsx Writer's handling of decimal commas [#1282](https://github.com/PHPOffice/PhpSpreadsheet/pull/1282) - Fix for issue by removing test code mistakenly left in [#1328](https://github.com/PHPOffice/PhpSpreadsheet/pull/1328) +- Fix return type in docblock for the Cells::get() [#1398](https://github.com/PHPOffice/PhpSpreadsheet/pull/1398) ## [1.10.1] - 2019-12-02