-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add Links on Save in Home Panel #57
Comments
Hey @Param302, I would like to work on this issue. please assign this to me. |
Sure @CodexRaunak ! Assigning you the issue. |
Hey @Param302 I want to ask when the user adds a valid URL in the edit section, then the link box will be created in the Home Panel. But if he adds the same URL again within the edit box, then what will happen? I have made the functionality till he adds and it gets saved in the home panel, but if he adds it again, then one more list box is created with the same key and value. Please clarify what is the ideal scenario, is it like user will edit the link and it will get added to the home panel, if there is already a same list box existing then it will not create a new box but update the previous one. Below is the image of the added code, please do let me know if there is any issue. |
oh oky, @CodexRaunak so it's a bug 😅 , we actually want all the links to be unique. Thanks for pointing out this bug! |
Add Links on Save in Home Panel
Overview
You have to implement add social link box functionality for Home panel which should create social link box whenever Save button is called.
Requirements
isValidURL()
function fromindex.js
to check whether a link is valid or not.createSocialLink(key, value)
function fromindex.js
, wherekey
can be retrieve fromsocialLinks
object andvalue
should be same as the provided link in input element oflink-box
in Edit panel.index.js
only.If you have any suggestion or idea, you're welcome to share.
Let's implement SocialRepo's save button functionality! 🙌
The text was updated successfully, but these errors were encountered: