Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add Links on Save in Home Panel #57

Open
Param302 opened this issue May 26, 2024 · 4 comments · May be fixed by #67
Open

[FEATURE] Add Links on Save in Home Panel #57

Param302 opened this issue May 26, 2024 · 4 comments · May be fixed by #67
Assignees
Labels
Code Coding issues enhancement New feature or request

Comments

@Param302
Copy link
Owner

Param302 commented May 26, 2024

Add Links on Save in Home Panel

Overview

You have to implement add social link box functionality for Home panel which should create social link box whenever Save button is called.

image
image

Requirements

  • After adding some links in Edit panel, whenever user clicks Save button, it should create link containers of those links in Home panel.
  • It should only create link containers of those links which are completed.
    • A link is completed, when there's no bottom line present below the link in Edit panel.
    • 2nd link shown in first image is completed link, others are invalid/incompleted links.
    • You can use isValidURL() function from index.js to check whether a link is valid or not.
    • Or you can check for CSS styling too, both should work.
  • It should create social link box same as provided in 2nd image.
  • For creating the social link box in home panel, you can use createSocialLink(key, value) function from index.js, where key can be retrieve from socialLinks object and value should be same as the provided link in input element of link-box in Edit panel.
  • Must follow the Code Guidelines provided.
  • To test the code, setup the extension by following these steps.
  • All the functionality should be implemented in index.js only.

If you have any suggestion or idea, you're welcome to share.

Let's implement SocialRepo's save button functionality! 🙌

@Param302 Param302 added enhancement New feature or request Code Coding issues labels May 26, 2024
@CodexRaunak
Copy link

Hey @Param302, I would like to work on this issue. please assign this to me.

@Param302
Copy link
Owner Author

Hey @Param302, I would like to work on this issue. please assign this to me.

Sure @CodexRaunak !

Assigning you the issue.

@CodexRaunak
Copy link

CodexRaunak commented Jun 13, 2024

Hey @Param302 I want to ask when the user adds a valid URL in the edit section, then the link box will be created in the Home Panel. But if he adds the same URL again within the edit box, then what will happen? I have made the functionality till he adds and it gets saved in the home panel, but if he adds it again, then one more list box is created with the same key and value.

Please clarify what is the ideal scenario, is it like user will edit the link and it will get added to the home panel, if there is already a same list box existing then it will not create a new box but update the previous one.

Below is the image of the added code, please do let me know if there is any issue.

addLink Box

@Param302
Copy link
Owner Author

oh oky, @CodexRaunak so it's a bug 😅 , we actually want all the links to be unique.
Right now, don't worry about it, as creating the home links will depends upon creating link in edit container, I will fix it.

Thanks for pointing out this bug!

@CodexRaunak CodexRaunak linked a pull request Jun 16, 2024 that will close this issue
9 tasks
@manpreetsingh04m manpreetsingh04m mentioned this issue Jun 28, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Coding issues enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants