fix: Descriptive statistics for number cells in data browser not showing #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
404-html
changed the title
Uffizzi Ephemeral Environment
|
404-html
changed the title
mtrezza
reviewed
Jul 26, 2024
mtrezza
approved these changes
Jul 26, 2024
|
Tested in preview environment, worked. |
mtrezza
changed the title
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 26, 2024
# [6.0.0-alpha.11](6.0.0-alpha.10...6.0.0-alpha.11) (2024-07-26) ### Bug Fixes * Descriptive statistics for number cells in data browser not showing ([#2581](#2581)) ([e146b6f](e146b6f))
|
🎉 This change has been released in version 6.0.0-alpha.11 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
As described here: #2574
Broken by: #2548
Closes: #2574
Approach
For some reason setting the state in
Browser.onMouseUpRowCheckBoxfunction (which is executed on every mouse up event) results inDataBrowser.componentWillReceivePropscall, where cells selection is wiped.I have not managed to find out why, so I changed the logic to set the state only if dragging actually started.
TODOs before merging
n/a