Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile inclusion #235

Closed
bernardocs opened this issue Jul 27, 2017 · 4 comments
Closed

Dockerfile inclusion #235

bernardocs opened this issue Jul 27, 2017 · 4 comments

Comments

@bernardocs
Copy link
Contributor

Hey guys!

I use this project as boilerplate of my project and I'm pretty satisfied with it.

I've been working on a Dockerfile for the project and wondered if anybody here have ever thought of creating one already. And if you did, why it was not already included?

I did a quick search through the issues section and didn't find any mention of it. I'm no Docker specialist as I'm using this oportunity to effectively learn more about it, but It would definitelly save the pain of going through known issues. 😄
@PatrickJS
Copy link
Owner

if you make a PR I wouldn't mind merging it

@bernardocs
Copy link
Contributor Author

bernardocs commented Jul 27, 2017 •
edited
Loading

I'm on it! 😄

But as I said, I'm learning about Docker while I'm on it...
So, I would appreciate some review!

I'll link a Pull Request here as soon as I make it work somehow...

@bernardocs
Copy link
Contributor Author

It's on! #236

@PatrickJS
Copy link
Owner

thanks, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bernardocs @PatrickJS