From e40b89011138b7d68006bff2bf858a244da1407d Mon Sep 17 00:00:00 2001
From: blockisec <62061776+blockisec@users.noreply.github.com>
Date: Sun, 21 Jan 2024 14:13:14 +0100
Subject: [PATCH] fix advisory cannot be created from finding (#142)

* closes #141
---
 server/backend/models/advisory.py            | 3 +--
 server/backend/tests/test_finding_viewset.py | 6 +++++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/server/backend/models/advisory.py b/server/backend/models/advisory.py
index 0f90533c..dcca566b 100644
--- a/server/backend/models/advisory.py
+++ b/server/backend/models/advisory.py
@@ -114,10 +114,9 @@ def create_from_finding(self, finding, **data):
         else:
             advisory.recommendation = finding.vulnerability.recommendation
         for proof in finding.findingimageattachment_set.all():
-            image_file = ImageFile(proof.image)
+            image_file = ImageFile(proof.image, name=proof.name)
 
             ImageAttachment.objects.create(
-                caption=proof.caption,
                 advisory=advisory,
                 image=image_file
             )
diff --git a/server/backend/tests/test_finding_viewset.py b/server/backend/tests/test_finding_viewset.py
index b7c7cca6..82450f9e 100644
--- a/server/backend/tests/test_finding_viewset.py
+++ b/server/backend/tests/test_finding_viewset.py
@@ -4,7 +4,7 @@
     VulnerabilityTemplate,
     Advisory,
     ProjectVulnerability,
-    ReportTemplate,
+    ReportTemplate
 )
 from backend.models.finding import FindingStatus, Severity
 from backend.models.account import Account
@@ -219,6 +219,10 @@ def setUp(self) -> None:
             "affected_versions": "234.2",
         }
 
+    def test_function(self):
+        advisory = Advisory.objects.create_from_finding(self.finding1, **self.data)
+        self.assertIsNotNone(advisory)
+
     def test_pentester1(self):
         self.client.force_login(self.pentester1)
         self.basic_status_code_check(self.url, self.client.post, 201, data=self.data)