Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with social links tuple #116

Closed
silverhook opened this issue Mar 31, 2014 · 3 comments
Closed

Bug with social links tuple #116

silverhook opened this issue Mar 31, 2014 · 3 comments

Comments

@silverhook
Copy link
Member

If I enter the following settings:

SOCIAL = (
    ('email', 'mailto:matija@suklje.name'),
    ('XMPP/Jabber', 'xmpp:matija.suklje@gabbler.org', 'comments-o'),
    ('LinkedIn', 'http://www.linkedin.com/in/silverhook', 'linkedin') ,
    ('Gitorious', 'https://gitorious.org/~hook', 'code-fork'),
    ('GitHub', 'https://github.com/silverhook', 'github-alt'),
    ('Bitcoin', 'http://matija.suklje.name/accepting-bitcoin-now', 'bitcoin')
    )

I would expect the social links to work fine, but what happens is that:

  • the first string gets correctly assigned to the title;
  • the last string correctly assigns the icon;
  • but the <a> link is not the second string, but just a lower-case first string appended to the site URL (e.g. http://matija.suklje.name/github

…from the above example only the email line parses correctly.

@talha131
Copy link
Member

Thanks, I have fixed it.

@talha131
Copy link
Member

Kindly test and let me know if the fix does not work!

@silverhook
Copy link
Member Author

Works, thanks @talha131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants