-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: install script gives fatal error when changing 'html' #391
Comments
Hey and thanks for the report. I hope to get needed fixes in today.. |
Hello, thank you for your answer. Unfortunately, I'm not quite fit enough
to understand what I should do now. Is this another installation script?
Andreas Blaesius ***@***.***> schrieb am Sa., 14. Okt. 2023,
09:08:
… Hey and thanks for the report. I hope to get needed fixes in today..
Maybe you can try and confirm it's working using
https://raw.githubusercontent.com/benjaminkott/photobooth/task/install-action/install-photobooth.sh
—
Reply to this email directly, view it on GitHub
<#391 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWPRUUNWQJOGQG3DFNS76Z3X7I25RAVCNFSM6AAAAAA57WOCPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRSGY3TENRVGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Updated version of the installer, yes
It should contain everything needed to fix the permission problem. |
I ran your new script on Raspberry Pi Is Lite 64. Unfortunately, there is
another error in npm. I have attached the error and part of the log file
Andreas Blaesius ***@***.***> schrieb am Sa., 14. Okt. 2023,
10:33:
… Updated version of the installer, yes
rm install-photobooth.sh
wget https://raw.githubusercontent.com/benjaminkott/photobooth/task/install-action/install-photobooth.sh
sudo bash install-photobooth.sh -username='<YourUsername>'
It should contain everything needed to fix the permission problem.
—
Reply to this email directly, view it on GitHub
<#391 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWPRUUIMKPCVFZBLFJZMJTDX7JE63AVCNFSM6AAAAAA57WOCPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRSG42DAOJZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
On Raspberry PI OS bookworm i get the same error with npm. I think the package from "apt" is the problem. When modifying your install script to always use the function "update_nodejs()" a newer version of npm will be installed with the updater from stanley. |
I am aware of and Nodejs via stanley is removed on the updated script I posted. @Notch001 nothing attached, use the Webinterface. |
Does not work on a fresh install (of bookworm) with the updated script. Installed Nodejs version from apt sources matches 18.17, so the photobooth install script never runs "update_nodejs()" and installer fails with:
Maybe a function to check npm version could be implementd, something like if $(npm -version) -le 9.6.0 -> run your updated part of nodejs update I ran that part (update_nodejs())) manually and rerun the photobooth installer, I get the following error and setup breaks:
For now I removed 'npm' from the extra packages, the installer runs until the end and photobooth is installed. |
Can you maybe tell me where you had to remove 'npm'?
deluxemongo ***@***.***> schrieb am Sa., 14. Okt. 2023, 16:05:
… I am aware of and Nodejs via stanley is removed on the updated script I
posted.
Does not work on a fresh install (of bookworm) with the updated script.
Installed Nodejs version from apt sources matches 18.17, so the photobooth
install script never runs "update_nodejs()" and installer fails with:
Cloning into '/var/www/html/vendor/Seriously'...
Submodule path 'vendor/Seriously': checked out '513d2b8696b76fe764b3033aa6dc7c99005acccd'
### Get yourself a hot beverage. The following step can take up to 15 minutes.
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: ***@***.***
npm ERR! notsup Not compatible with your version of node/npm: ***@***.***
npm ERR! notsup Required: {"node":">=18.17.0","npm":">=9.6.0"}
npm ERR! notsup Actual: {"npm":"9.2.0"}
Maybe a function to check npm version could be implementd, something like
if $(npm -version) -le 9.6.0 -> run your updated part of nodejs update
I ran that part (update_nodejs())) manually and rerun the photobooth
installer, I get the following error and setup breaks:
[Package] Installing missing common package: npm
E: Unable to correct problems, you have held broken packages.
For now I removed 'npm' from the extra packages, the installer runs until
the end and photobooth is installed.
—
Reply to this email directly, view it on GitHub
<#391 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWPRUUNFWB2RZN62UHNAE6TX7KLYZAVCNFSM6AAAAAA57WOCPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRSHEZDIOJQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
For my described case, (install fails, manually update npm, rerun installer) I commented this line: EXTRA_PACKAGES+=('npm') But this is not the best way. If you are not familiar I think you should wait for the devolpers until the fix the problem within the installer. Aside from that this case is about permission errors on html folder and not a wrong npm version (on bookworm). The original posted bug seems to be fixed. |
Installer should be fixed now. If possible please do a fresh install of PiOS and try again. |
Yes, I did a fresh install and everything worked fine. Thanks
Andreas Blaesius ***@***.***> schrieb am Mo., 16. Okt. 2023,
12:52:
… Closed #391 <#391>
as completed.
—
Reply to this email directly, view it on GitHub
<#391 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWPRUUNTWCE26GCWLONOWLLX7UGXTAVCNFSM6AAAAAA57WOCPOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGY3DGNRWGU3TENQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Thanks for testing. 👍😊
Now we also check for the minor version string of Node.js and suggest an update if needed. |
Describe the bug
Hello, I received an fatal Error several times when running the installation script. If the script makes changes to the HTML folder, it gives the error "fatal error permission denied"I tried with several versions and also set the permissions for the folder manually beforehand. Unfortunately no success. The last attempt was with Raspberry PI OS Desktop on a Raspberry Pi 4 64 bit
Steps to reproduce the behavior
Simply run the installation script
Expected behavior
To install the software
Photobooth Version
Latest, link from wget in instructions
Browser and browser version
No response
Operating System
Raspberry PI OS with Desktop
Did it work before?
No
Latest working version
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: