Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use more kinds (or even ANY kind) of blocks to serve as a solid furniture's hitbox #2327

Closed
4 tasks done
AllayBreeze opened this issue Feb 5, 2023 · 1 comment
Closed
4 tasks done
Labels
type: duplicate This issue or pull request already exists type: feature request Feature request.

Comments

@AllayBreeze
Copy link

AllayBreeze commented Feb 5, 2023

Terms

  • I'm using the very latest version of ItemsAdder and its dependencies.
  • I already searched on this Github page to check if the same suggestion was already reported.
  • I already searched on the plugin wiki to know if the feature is already implemented.
  • I already searched on the Discord server to know if anyone already has a solution for this or if the feature was already suggested.

Discord tag (optional)

Raenzil#7359

Describe the solution you'd like

It is not perfect to just use barriers as hitboxes for various kinds of furniture. Since a server uses the furniture function, a resourse pack will be must needed, and at the same time, the texture of all blocks can be redesigned, so that more kinds of fully transparent blocks are able to be made. Therefore, can it be an additional option to allow setting the block types of the furniture hitbox?
Some application examples:

  1. Create a kind of REAL_TRANSPARENT or REAL_WIRE block and make it totally transparent, then use it as a furniture's hitbox.
  2. Give some kinds of blocks totally transparent textures and use them on furniture:
    (1) Campfires. Perfect to make half height furnitures and slabs.
    (2) Tripwire hooks. For servers enabling REAL_WIRE, tripwire hooks are usually not used anymore, so they can also be used as hitboxes.
    (3) Spawners/Shulker boxes. To make opaque furniture. Shulker boxes can also be used to make containers.
    (4) Chests. To make hitboxes with 14 length and width, or be used to make containers.
    (5) Player heads/Mob skulls. To make hitboxes with 8 length and width.
    (6) By modifying the minecraft shader core, there'll be even more blocks such as fence/fence gate/door/trapdoor/button/pressure plate/etc. that can be changed into transparent, to make more kinds of these functional blocks or other things.
  3. Even if blocks have not changed their textures at all, they are still suitable to be used as furniture hitboxes at some times. Such as using lily pad to make a furniture "Lily flower", only the flower's model will be needed to make, and the furniture will be able to have same properties as normal lily pads (e.c. can be put onto water).

Is your feature request related to a problem?

No. It's just a new idea.

Describe alternatives you've considered

These expansion methods seem also to be quite suitable for TILE blocks? Maybe they can also be used to expand the hitbox kinds of TILEs.

Additional context

My idea for configurations:
behaviours:
furniture:
solid: true
solid_hitbox_block: CAMPFIRE #BARRIER for default if this attribute is not set. If want to use a custom block use format like namespace:id.
hitbox_has_functions: true #If using containers, campfires or some other functional blocks as hitbox, set if their functions can be used or not.

Since blocks that are not barriers are hard to deal with custom hitboxes, I think it's good to disable custom hitboxes if not using BARRIER.

@AllayBreeze AllayBreeze added the type: feature request Feature request. label Feb 5, 2023
@LoneDev6
Copy link
Collaborator

LoneDev6 commented Feb 6, 2023

Duplicate of #805

By modifying the minecraft shader core, there'll be even more blocks such as fence/fence [...]

Shaders code won't be modified because tons of people will blame your server for not working correctly.
These people are the users using shaders mods which are not compatible with resourcepack shaders.
Read more here:
IrisShaders/Iris#1042
sp614x/optifine#6391

There seem to be no way for shaders mods developers to support resourcepack shaders.

You will now surely want to tell me: "But I don't care if a person is using shader mods! If they want to play on my server they must disable them!"
You will lose a lot of players because of that, so you should really consider this a valid argument, a lot of people use shaders mods to play Minecraft now days, we must continue providing a complete experience also for these users.

@LoneDev6 LoneDev6 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2023
@PluginBugs PluginBugs locked and limited conversation to collaborators Feb 6, 2023
@LoneDev6 LoneDev6 added the type: duplicate This issue or pull request already exists label Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: duplicate This issue or pull request already exists type: feature request Feature request.
Projects
None yet
Development

No branches or pull requests

2 participants