New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that parameter rounding isn't permitted except as a step within uprating #216

Open

anth-volk opened this issue Jun 7, 2024 · 0 comments

Contributor

anth-volk commented Jun 7, 2024

At the moment, rounding within parameter calculation is permitted both alongside uprating (see Vermont, https://github.com/PolicyEngine/policyengine-us/blob/8655d2b86d0bb835b6fa8a26d1a6ae87832fdeeb/policyengine_us/parameters/gov/states/vt/tax/income/rates/joint.yaml#L28) and within uprating (see Rhode Island, https://github.com/PolicyEngine/policyengine-us/blob/8655d2b86d0bb835b6fa8a26d1a6ae87832fdeeb/policyengine_us/parameters/gov/states/ri/tax/income/exemption/amount.yaml#L14). As a result, Vermont's parameter here is not successfully uprated. We should add error handling to ensure that parameter rounding only occurs within the context of uprating, as well as fix those variables which fail this check within the relevant country packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment