Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of ethers is breaking the build 🚨 #474

Closed
greenkeeper bot opened this issue Dec 14, 2018 · 2 comments
Closed

An in-range update of ethers is breaking the build 🚨 #474

greenkeeper bot opened this issue Dec 14, 2018 · 2 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Dec 14, 2018

The dependency ethers was updated from 4.0.18 to 4.0.19.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ethers is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build is in progress (Details).
  • ci/circleci: Build Error: Your tests failed on CircleCI (Details).

Commits

The new version differs by 6 commits.

  • 26eb6cc Updated dist files.
  • bcba17a Allow nonce to be a BigNumber (#228).
  • 918b66b Fixed typo in error strings (#376).
  • 152d672 Add isHexString to exported utils (#367).
  • 51fb472 Add abs method to BigNumber (#375).
  • 66440b8 Better error messages for namehash (#364).

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Dec 14, 2018

After pinning to 4.0.18 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@maxsam4
Copy link
Contributor

maxsam4 commented Dec 15, 2018

Ethers update does not have any breaking changes. Build is failing because these branches are created off master and circle config hasn't been merged into master yet. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant