Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitVersion.yml is missing #1

Open
FISHMANPET opened this issue Aug 23, 2019 · 1 comment
Open

GitVersion.yml is missing #1

FISHMANPET opened this issue Aug 23, 2019 · 1 comment
Labels
question Further information is requested

Comments

@FISHMANPET
Copy link
Contributor

FISHMANPET commented Aug 23, 2019

The readme links to GitVersion.yml in master but that file doesn't exist currently (and I'm not sure it's ever existed in this repo). Would this version from ModuleBuilders be of the right default format? https://github.com/PoshCode/ModuleBuilder/blob/master/GitVersion.yml

@Jaykul
Copy link
Member

Jaykul commented Sep 11, 2019

Yes.

It shouldn't really matter what you have in your GitVersion, but I'll have to add that content to the ReadMe or something...

I obviously have some weird extra code to build a counter variable based on the output of GitVersion in order to update the output of GitVersion -- and that only works if you have a version format configuration that uses {env:BUILDCOUNT ?? 0}

At work, we really like GitVersion, but we still feel that every build should have a different number (we put it in the SemVer metadata, not the actual version number) in case you build the same source twice and get different results because of environmental changes...

@Jaykul Jaykul added the question Further information is requested label Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants