Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

New resource module : AppFabric #184

Open
luigilink opened this issue Sep 2, 2016 · 12 comments
Open

New resource module : AppFabric #184

luigilink opened this issue Sep 2, 2016 · 12 comments
Labels
in progress The issue is being actively worked on by someone. new module submission A request that the community evaluate a resource module for submission into the DSC Resource Kit.

Comments

@luigilink
Copy link

I work on a new resource for SharePoint DSC : Installation of Cumulative update for AppFabric : dsccommunity/SharePointDsc#394

This resource is not used only by sharepoint so, it will be interesting to create a new module with this resource and other like Installation of AppFabric binaries, start/stop service, manage configuration, etc..

Thanks in advance for your help.

@luigilink
Copy link
Author

luigilink commented Oct 17, 2016

Here you can find the Url of this new DSC module
https://github.com/luigilink/AppFabricDsc

  • Ensure your new resource module is in its own public repository.
  • Ensure your new repository is under the MIT license.
  • Ensure your new resource module follows the High Quality DSC Resource Module Guidelines.
    I try the best I can :)
  • Set up a review pull request - Completed
  • Submit an issue in the main DSC Resource Kit repository with a link to your repository.

Can I have some help on "the empty branch" (PR review)?

@mbreakey3
Copy link
Member

Yes - did you read over the new resource module submissions page? If you're still running into specific issues on this, let me know.

@mbreakey3
Copy link
Member

Also, make sure it follows the uniform folder format as well as the other High Quality requirements

@luigilink
Copy link
Author

To be more closed to SharePointDsc and OfficeOnlineDsc, I copy/paste OfficeOnlineDsc and I adapt it for AppFabricDsc. So I have the same folders tree.

@luigilink
Copy link
Author

luigilink commented Oct 18, 2016

Impossible to merge dev or master in reviewBase: fatal: refusing to merge unrelated @histories
[Update]: I add the parameter allow-unrelated-histories git merge dev --allow-unrelated-histories

Review Pull Request: luigilink/AppFabricDsc#6

@luigilink
Copy link
Author

What's the next step ?

@mbreakey3
Copy link
Member

It will need to be reviewed by the new module review team, but in the mean time, make sure it's following all of the High Quality requirements, as that will speed up the review process.

@kwirkykat kwirkykat added new module submission A request that the community evaluate a resource module for submission into the DSC Resource Kit. needs review The pull request needs a code review. and removed module proposal labels Oct 21, 2016
@johlju
Copy link
Contributor

johlju commented Apr 16, 2018

Are there still interest of adding the AppFabricDsc resource module to the DSC Resource Kit?
If so I like to help getting this reviewed according to the new process of getting a resource module added to the DSC Resource Kit.
I have opened an issue to update the text on How to do a new resource module submission,
but basically if we gonna submit this resource module to DSC Resource Kit we need to make sure it follows the Quality Governance.

@johlju
Copy link
Contributor

johlju commented May 30, 2018

@luigilink are you still interested in linking your resource module to DSC Resource Kit? You will still keep it in your own repo. Let me know if you still want to do this and I will provide the steps to link it here. If you don't want to do this, then I suggest we close this issue. 🙂

@johlju johlju added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. needs more information The issue needs more information from the author or the community. and removed needs review The pull request needs a code review. waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels May 30, 2018
@luigilink
Copy link
Author

@johlju Yes still interested. Tell me exactly what to do and I'll do it 😸

@johlju
Copy link
Contributor

johlju commented May 31, 2018

I have sent in a PR that adds the steps to do a new module submission, until that is accepted, please look here at the proposed texts.

New module submission: https://github.com/johlju/DscResources/blob/b899c99aa1cab6a481c060c26ab0db5e6e4d4d9c/NewResourceModuleSubmissions.md

Issue template: https://github.com/johlju/DscResources/blob/b899c99aa1cab6a481c060c26ab0db5e6e4d4d9c/.github/ISSUE_TEMPLATE/New_resource_module_submission.md

@johlju johlju added in progress The issue is being actively worked on by someone. and removed needs more information The issue needs more information from the author or the community. labels May 31, 2018
@johlju
Copy link
Contributor

johlju commented Sep 22, 2018

@luigilink have you thought anything more around this? Are you still interested so we should keep the issue open?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress The issue is being actively worked on by someone. new module submission A request that the community evaluate a resource module for submission into the DSC Resource Kit.
Projects
None yet
Development

No branches or pull requests

4 participants