-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: 7.2.0-preview.2 changes #14433
Conversation
Co-authored-by: Robert Holt <rjmholt@gmail.com>
Add CHANGELOG for 7.2.0-preview.2
…kage Fix release pipeline by skipping the global tool package
Once this is approved I'll need to create a merge commit manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For changes except for the changelog, do we need to take them back?
@@ -30,7 +30,7 @@ steps: | |||
$releaseVersion = Get-Content "$ENV:PIPELINE_WORKSPACE/releasePipeline/metadata/release.json" | ConvertFrom-Json | Select-Object -ExpandProperty 'ReleaseVersion' | |||
$globalToolPath = "$ENV:PIPELINE_WORKSPACE/releasePipeline/finalResults/PowerShell.$releaseVersion.nupkg" | |||
### -WhatIf to make sure we do not release global tool. Remove -WhatIf when the PowerShell name reservation is done. | |||
Copy-Item $globalToolPath -Destination "$(Pipeline.Workspace)/release" -WhatIf | |||
### Copy-Item $globalToolPath -Destination "$(Pipeline.Workspace)/release" -WhatIf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall this change be taken back to GH master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it shouldn't be -- I'll remove it
Closed in favour of #14434 |
PR Summary
Changes made for the 7.2.0-preview.2 release.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.