Files are not closed in workspace service in Linux

[fflaten]

Prerequisites

• Write a descriptive title.
• Make sure you are able to repro it on the latest version
• Search the existing issues.

Steps to reproduce

1. Open a new instance of VSCode on Linux
2. Open a file
3. Test symbol search. It will show symbols in file
4. Close file
5. Test symbol search again.

They will still be there even though workspace symbols (search) should only track open files

Expected behavior

File will be closed -> no symbols shown in symbol search

Actual behavior

Files are added on open, but never closed. -> symbol search shows values for every file opened or scanned at some point

Error details

No response

Environment data

Name                           Value
----                           -----
PSVersion                      7.2.3
PSEdition                      Core
GitCommitId                    7.2.3
OS                             Linux 5.10.102.1-microsoft-standard-WSL2 #1 SMP Wed Mar 2 00:30:59 UTC 2022
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Version

2022.8.2 preview

Visuals

No response

[fflaten]

This is caused by a casing mismatch in keys. Files are added to workspaceFiles using real path on linux, but removed using ScriptFile.Id which is always FilePath.ToLower().