Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: creates and implements WorkQueueStatusBadge component #743

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

space-age-pete
Copy link
Contributor

Introduces new WorkQueueStatusBadge and implements it wherever Work Queue Status/health is being displayed.

Current design uses existing state colors, and little colored dots, but this could change.

image
image

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for orion-design ready!

Name Link
🔨 Latest commit f99cf69
🔍 Latest deploy log https://app.netlify.com/sites/orion-design/deploys/63601238253e39000882d319
😎 Deploy Preview https://deploy-preview-743--orion-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stackoverfloweth
Copy link
Contributor

Is it just me, or do others thing "status:paused" needs a dot too? Just for alignment?

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks great 👍🏻

@znicholasbrown
Copy link
Contributor

I actually like that small difference since a paused work queue doesn't have a health state but I'm not wed to it either

Copy link
Contributor

@stackoverfloweth stackoverfloweth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some high quality PR'n my friend.

src/components/WorkQueueStatusBadge.vue Outdated Show resolved Hide resolved
@space-age-pete space-age-pete merged commit 9c84161 into main Oct 31, 2022
@space-age-pete space-age-pete deleted the work-queue-status-badge branch October 31, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants