Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC TODO #218

Open
2 of 20 tasks
Hlavtox opened this issue Mar 25, 2022 · 6 comments
Open
2 of 20 tasks

EPIC TODO #218

Hlavtox opened this issue Mar 25, 2022 · 6 comments
Labels
Bug Something isn't working EPIC A list of issues Improvement Refactoring Cleaning and improving the internal structure

Comments

@Hlavtox
Copy link
Contributor

Hlavtox commented Mar 25, 2022

General ideas to explore and check

  • Find a way to build module specific styles into separate CSS files. We don't want to include everything in the main theme.css, when some users won't use half of these styles and scripts.
  • We need to check that styles belong to core/custom properly. When building the theme without custom scss, we should get a solid pure boostrap base.
  • Perform cleaning and optimization regularily, simplify to the maximum.
  • We need to backport all classic theme fixes implemeted since we started building this.

Bugs and things missing

Product page

Images

Checkout

  • displayCarrierExtraContent hook is working, but is not appearing and disappearing dynamically, only on page load
  • Linklist module is using footer template in left column.

Category

  • Desktop nouislider not working after resizing the screen and opening and closing mobile filters
  • Style category left column module
  • Prepare hidden component for listing pagination and show all button, for theme developers. 🔴 ResultsPerPage parameter should support something like "all", one could set it to 9999, but that smells.
  • Prepare hidden support for add to cart button that works and doesn't have bugs.
  • Prepare hidden support for showing short description on product list. Small font, with removed HTML tags and truncated.
  • Mobile filters - put green OK button that closes the sidebar to the bottom, so the user can have one more way to go outside.
  • Search suggestions in empty category do not work, only in header.
  • Page jumping to the top after selecting filters.
  • After selecting some filters, products in category are 1 column on display < 1200px.
  • Price filter - wrong format of numbers. No space between thousands and . instead of , for decimal places. OK in active filters section.

My account

General

  • IDEA - YML configuration options for every theme - Something like wordpress theme customizer. Every merchant could then easily customize the theme colors etc. It would contain a a set of options for the theme, without any configuration modules that are usually shipped with the theme. It could contain dropdowns, radios, inputs etc. Prestashop would load it dynamically load them from the YML, present them and provide saving their values. 🔴 NEED DEV POWER 🔴 NEED PRODUCT TEAM
  • Module for homepage content - banners/categories/texts/etc - some kind of visual builder. Banner module is obsolete - 1 image in 2022? Nooooo. 🔴 NEED DEV POWER 🔴 NEED PRODUCT TEAM
  • Think about unifying the order summary table on confirmation and tracking page.
@matks
Copy link
Contributor

matks commented Mar 25, 2022

IDEA - YML configuration options for every theme - Something like wordpress theme customizer. Every merchant could then easily customize the theme colors etc. It would contain a a set of options for every theme - dropdowns, radios, inputs etc. Prestashop would load it dynamically load and present them from the YML. 🔴 NEED DEV POWER 🔴 NEED PRODUCT TEAM

This would be done in the Core if I am not wrong. Else no other theme will follow.

Every merchant could then easily customize the theme colors etc.

Please lower your expectations :p we can build it but we cannot force theme developers to apply it

What about this issue? PrestaShop/PrestaShop#26849 🔴

I added a suggestion inside the issue to make some progress. I think it should be something pretty simple :)

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Mar 25, 2022

Please lower your expectations :p we can build it but we cannot force theme developers to apply it

Wrong wording, of course :D

@mparvazi
Copy link
Member

mparvazi commented Mar 25, 2022

Product image thumbnails are not carousal, so we have over-height in modal view even for on-line thumbnails.

Screenshot 2022-03-25 at 20-54-01 Women

@mparvazi
Copy link
Member

@Hlavtox

The config rules in theme.yml must be converted to a css file (e.g. override.css)
But the styling rules have been implemented by scss, so it would be error prone.

Currently we have this problem in RTL for BO. The rules for fixing RTL issues are in css (theme.rtlfix) but BO theme styled by scss.

I mean, something like this makes it harder for theme maintainability.

@Hlavtox
Copy link
Contributor Author

Hlavtox commented May 11, 2022

@mparvazi @NeOMakinG List updated with things I found yesterday. Let's do this!

@Hlavtox Hlavtox added Bug Something isn't working EPIC A list of issues Refactoring Cleaning and improving the internal structure Improvement labels May 12, 2022
@Hlavtox Hlavtox pinned this issue Jul 9, 2022
@Hlavtox Hlavtox changed the title Primary issues list to fix EPIC TODO Jul 9, 2022
@amaury-hanser
Copy link

IDEA - YML configuration options for every theme - Something like wordpress theme customizer. Every merchant could then easily customize the theme colors etc. It would contain a a set of options for the theme, without any configuration modules that are usually shipped with the theme. It could contain dropdowns, radios, inputs etc. Prestashop would load it dynamically load them from the YML, present them and provide saving their values. red_circle NEED DEV POWER red_circle NEED PRODUCT TEAM

We plan to add this feature in a module, test it and contribute to the core if it works and if the community follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working EPIC A list of issues Improvement Refactoring Cleaning and improving the internal structure
Projects
Status: No status
Development

No branches or pull requests

4 participants